Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gap between student card and footer + Fixed Some darkmode Bugs #1311 #1313

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Gap between student card and footer + Fixed Some darkmode Bugs #1311 #1313

merged 2 commits into from
Jul 30, 2024
+30 −3

Conversation

nishant0708
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #1311

Replace issue_no with the issue number which is fixed in this PR

Screenshots

Screenshot 2024-07-30 111043
Screenshot 2024-07-30 111048
Screenshot 2024-07-30 111053
Screenshot 2024-07-30 111058

Checklist

  • [X ] Tests have been added or updated to cover the changes
  • [X ] Documentation has been updated to reflect the changes
  • [X ] Code follows the established coding style guidelines
  • [X ] All tests are passing

@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for counsellor-startup ready!

Name Link
🔨 Latest commit 348cbfb
🔍 Latest deploy log https://app.netlify.com/sites/counsellor-startup/deploys/66a8cf52e4f3900008672ba7
😎 Deploy Preview https://deploy-preview-1313--counsellor-startup.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 71
Accessibility: 96
Best Practices: 100
SEO: 67
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@nishant0708 nishant0708 changed the title Gap between student card and footer + Fixed Some darkmode Bugs ( Extra) #1311 Gap between student card and footer + Fixed Some darkmode Bugs #1311 Jul 30, 2024
@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Jul 30, 2024 •
edited
Loading

Here's the code health analysis summary for commits d3c6cce..348cbfb. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@thestarsahil
Copy link
Collaborator

@nishant0708 Still their is a gap

@nishant0708
Copy link
Contributor Author

hey @thestarsahil
image
there is no gap in my end can you send me a ss

@thestarsahil thestarsahil merged commit 6e8997c into Counselllor:master Jul 30, 2024
6 checks passed
@thestarsahil thestarsahil added gssoc for GSSOC'24 contributors level1 labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestarsahil thestarsahil thestarsahil approved these changes

Assignees
No one assigned
Labels
gssoc for GSSOC'24 contributors level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gap between student card and footer
2 participants
@nishant0708 @thestarsahil